Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to show SafariView in nested sheets #20

Closed
wants to merge 1 commit into from

Conversation

twodayslate
Copy link

See #8

@stleamist
Copy link
Owner

Hi @twodayslate,

Thank you for your contribution! I have checked that your PR fixes the issue and working well :)

However, I'm sorry that it will not be merged because v2.4.0 (which migrates SafariViewPresenter to UIViewRepresentable in 6e10ed3) also contains a bug fix for the issue you have reported.

I hope you understand, and I really appreciate your contribution!

@stleamist stleamist closed this Sep 25, 2021
@stleamist stleamist added the bug Something isn't working label Sep 25, 2021
@stleamist stleamist self-assigned this Sep 25, 2021
@stleamist stleamist linked an issue Sep 25, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safari View Controller not presented
2 participants