XML toJSONObject(Reader reader)

[foldvari]

What problem does this code solve?

• Currently converting XML to JSON can be done using toJSONObject(String string) method only. In case of huge XML-s the need to convert them to string is very memory consuming. This limits usability.
  As JSONTokener is working with a Reader anyway, introducing a new method in the XML class which accepts a Reader is a very simple, risk free change.

Risks

• Low

Changes to the API?

• 3 additional methods.

Will this require a new release?

• No

Should the documentation be updated?

• Not necessary

Does it break the unit tests?

• No. Existing unit tests validate this change as well.

Was any code refactored in this commit?

• XML.java toJSONObject(String string, boolean keepStrings) now converts String to Reader

Review status
ACCEPTED
Starting 3 day comment window

[johnjaylward]

These changes look good to me. Straight forward and relatively simple.

[stleary]

Thanks for the pull request. Accepted, starting comment window.