Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONTokener(InputStream) violates rfc8259#section-8.1 (#739) #740

Merged
merged 1 commit into from
May 28, 2023
Merged

JSONTokener(InputStream) violates rfc8259#section-8.1 (#739) #740

merged 1 commit into from
May 28, 2023

Conversation

michael-o
Copy link
Contributor

Always use UTF-8 when an InputStream is passed.

This fixes #739.

Always use UTF-8 when an InputStream is passed.

This fixes #739.
@stleary
Copy link
Owner

stleary commented May 25, 2023

What problem does this code solve?
Resolves a non-compliant part of the lib - JSON text should use UTF-8.

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
N/A

Does it break the unit tests?
No, and no new tests were added.

Was any code refactored in this commit?
No

Review status
Approved

Starting 3-day comment window.

@michael-o Good catch

@stleary stleary merged commit 22ccf1b into stleary:master May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONTokener(InputStream) violates rfc8259#section-8.1
2 participants