Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation for MSVC #1176

Merged
merged 5 commits into from
Aug 13, 2021
Merged

Conversation

slyshykO
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@gszy gszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rearrange this PR so that the coding style changes and the actual compilation fixes are in separate commits?

@slyshykO
Copy link
Collaborator Author

@gszy removed all code style changes

@Nightwalker-87 Nightwalker-87 changed the title fix compilation for MSVC Fixed compilation for MSVC Aug 13, 2021
Copy link
Collaborator

@gszy gszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a few coding style-related suggestions. Feel free to ignore them, I don’t see any serious issues, though I think it would be nice to fix the ones I’ve spotted.

src/stlink-lib/chipid.c Show resolved Hide resolved
src/stlink-lib/chipid.c Show resolved Hide resolved
src/stlink-lib/chipid.c Show resolved Hide resolved
src/stlink-lib/chipid.c Show resolved Hide resolved
src/stlink-lib/chipid.c Outdated Show resolved Hide resolved
src/stlink-lib/chipid.c Outdated Show resolved Hide resolved
src/stlink-lib/chipid.c Outdated Show resolved Hide resolved
Nightwalker-87 and others added 2 commits August 13, 2021 21:23
Co-authored-by: Grzegorz Szymaszek <gszymaszek@short.pl>
Co-authored-by: Grzegorz Szymaszek <gszymaszek@short.pl>
@slyshykO
Copy link
Collaborator Author

slyshykO commented Aug 13, 2021

@Nightwalker-87 Will running uncrustify on "chipid.c" help?

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Aug 13, 2021

Yes, I think so - this was the original intention for /config/code_style.cfg at least.
I personally use it and believe the configuration to be working.
Please let me know if this should not always be the case.

@Nightwalker-87
Copy link
Member

Looks good. 👍

@Nightwalker-87 Nightwalker-87 merged commit a6d19d7 into stlink-org:develop Aug 13, 2021
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Aug 13, 2021
@slyshykO slyshykO deleted the fix-msvc-build branch January 15, 2023 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants