-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed compilation for MSVC #1176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rearrange this PR so that the coding style changes and the actual compilation fixes are in separate commits?
f111ebf
to
508acfe
Compare
@gszy removed all code style changes |
e96698d
to
41d7ca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a few coding style-related suggestions. Feel free to ignore them, I don’t see any serious issues, though I think it would be nice to fix the ones I’ve spotted.
Co-authored-by: Grzegorz Szymaszek <gszymaszek@short.pl>
Co-authored-by: Grzegorz Szymaszek <gszymaszek@short.pl>
@Nightwalker-87 Will running uncrustify on "chipid.c" help? |
Yes, I think so - this was the original intention for /config/code_style.cfg at least. |
Looks good. 👍 |
No description provided.