Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated chip config files from the library structs #1181

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Updated chip config files from the library structs #1181

merged 1 commit into from
Aug 29, 2021

Conversation

gszy
Copy link
Collaborator

@gszy gszy commented Aug 21, 2021

In general, the chip config files should be kept in sync with the old
library structs. Regenerate the files (using an ad hoc script) from the
current library.

The file name is generated from the chip description, all
non-alphanumeric characters are replaced with underscores. It turns out
some files have to have their names changed.

See #1180 (comment) and #1180 (comment).

@gszy
Copy link
Collaborator Author

gszy commented Aug 21, 2021

(Some? All?) CI failures seem unrelated:

E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/m/mesa/libegl-mesa0_21.0.3-0ubuntu0.2~20.04.1_amd64.deb  404  Not Found [IP: 40.119.46.219 80]

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Aug 21, 2021

Need to check, likely to be unrelated to the content indeed...

@Nightwalker-87
Copy link
Member

It's obviously a temporary bug in the respective GitHub Actions Build Environment - we should wait for it to be fixed before merging.
However your contribution looks fine to me. 🥇

@Nightwalker-87
Copy link
Member

It seems to be this issue (apparently an evergreen): actions/runner-images#675

@Nightwalker-87
Copy link
Member

@gszy The latest commit fixes the issue within the GH Actions workflow routine.
Applying it to this PR should let all tests pass successfully.

In general, the chip config files should be kept in sync with the old
library structs. Regenerate the files (using an ad hoc script) from the
current library.

The file name is generated from the chip description, all
non-alphanumeric characters are replaced with underscores. It turns out
some files have to have their names changed.
@gszy
Copy link
Collaborator Author

gszy commented Aug 29, 2021

@Nightwalker-87, done. I think this commit, if merged, should be followed by a commit that would remove the old library struct completely.

@Nightwalker-87 Nightwalker-87 changed the title Update chip config files from the library structs Updated chip config files from the library structs Aug 29, 2021
@Nightwalker-87 Nightwalker-87 merged commit 7c4ad1c into stlink-org:develop Aug 29, 2021
@Nightwalker-87
Copy link
Member

@gszy Thank you so much! 🥇

@stlink-org stlink-org locked as resolved and limited conversation to collaborators Aug 29, 2021
@gszy gszy deleted the chip-files branch August 29, 2021 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants