Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Fix relative path to the UI files needed by stlink-gui-local #771

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

p12tic
Copy link
Contributor

@p12tic p12tic commented Feb 16, 2019

Fixes #770.

Either of the following work now:

  • mkdir build; pushd build; cmake ..; make -j32 all; ./src/tools/gui/stlink-gui-local; popd

  • cmake .; make -j32 all; ./src/tools/gui/stlink-gui-local

This issue most likely has been caused by 4209e4b, as CMAKE_CURRENT_SOURCE_DIR is interpreted as currently processed source directory and that changed by moving cmake source to different directory.

@xor-gate xor-gate added this to the Next milestone Feb 16, 2019
@xor-gate xor-gate merged commit 1165cf7 into stlink-org:master Feb 16, 2019
@xor-gate
Copy link
Member

Thanks!

@Nightwalker-87 Nightwalker-87 removed this from the General milestone Feb 21, 2020
@Nightwalker-87 Nightwalker-87 self-assigned this Feb 21, 2020
@Nightwalker-87 Nightwalker-87 added this to the v1.6.0 milestone Feb 21, 2020
@p12tic p12tic deleted the fix-gui-local-ui-path branch March 20, 2020 17:35
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stlink-gui fails to start due to failure to load UI file in source build
3 participants