Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc/trivial] Fix st-flash manpage read example #858

Closed
wants to merge 1 commit into from
Closed

[doc/trivial] Fix st-flash manpage read example #858

wants to merge 1 commit into from

Conversation

yumkam
Copy link
Contributor

@yumkam yumkam commented Jan 29, 2020

SIZE must be specified as hexdecimal number (as per both documentation and implementation), current manpage example unexpectedly reads 0x4096 (16534) bytes instead of 4096 (0x1000).
(actually, 0x prefix is not necessary, number interpreted as hexdecimal anyway, and maybe confusing readers into thinking that number will be interpreted as decimal [without prefix] or octal [with 0 prefix])

Size must be specified as hexdecimal number (as per both documentation
and implementation)
Copy link
Member

@Nightwalker-87 Nightwalker-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Nightwalker-87
Copy link
Member

@yumkam: Thx for your contribution!

@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 27, 2020
@yumkam yumkam deleted the fix-st-flash-man-size branch July 9, 2020 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants