Error return in failed probe (Fixes #887) #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 21, 2020
|
Nightwalker, I messed things up, it seems. I didn't do what I wanted to do. Can you get this fixed, integrated for me, or do you want me to try to fix it again? |
|
@rewolff: Don't bother about this too much. I had some troubles with proper merging on the I'll rebase this one for you and suggest that you move over to the |
Nightwalker-87
approved these changes
Mar 21, 2020
Nightwalker-87
changed the title
|
@rewolff: Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate pull request for separate issue. On error in probe, the 1.6 version did not error out. This seems due to wanting to save a couple of lines that didn't work out. I added the two necessary lines.