Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OutputPin impl for Alternate mode pins #103

Merged
merged 1 commit into from
Aug 18, 2019
Merged

Remove OutputPin impl for Alternate mode pins #103

merged 1 commit into from
Aug 18, 2019

Conversation

TheZoq2
Copy link
Member

@TheZoq2 TheZoq2 commented Aug 18, 2019

Closes #102

therealprof
therealprof requested changes Aug 18, 2019
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG entry.

@TheZoq2
Copy link
Member Author

TheZoq2 commented Aug 18, 2019

Oh yes, good idea. A new commit has been pushed

therealprof
therealprof approved these changes Aug 18, 2019
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@therealprof therealprof merged commit 9c9c6e1 into stm32-rs:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPIO output toggling does not work on Alternate pins
2 participants
@TheZoq2 @therealprof