Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RTFM-based examples #173

Merged
merged 5 commits into from
Jan 21, 2020
Merged

Update RTFM-based examples #173

merged 5 commits into from
Jan 21, 2020

Conversation

eupn
Copy link
Contributor

@eupn eupn commented Jan 21, 2020

This PR bumps the RTFM version to 0.5.x and refactors RTFM-based examples to the newer RTFM API.

@eupn eupn requested a review from Disasm January 21, 2020 04:52
@Disasm
Copy link
Member

Disasm commented Jan 21, 2020

As for the usb_serial_rtfm example, change looks good to me.

@eupn eupn requested a review from TeXitoi January 21, 2020 06:58
TeXitoi
TeXitoi approved these changes Jan 21, 2020
View reviewed changes
examples/timer-interrupt-rtfm.rs Outdated Show resolved Hide resolved
examples/timer-interrupt-rtfm.rs Outdated Show resolved Hide resolved
examples/usb_serial_rtfm.rs Outdated Show resolved Hide resolved
@TeXitoi
Copy link
Contributor

TeXitoi commented Jan 21, 2020

Thanks for the update!

@eupn eupn requested a review from therealprof January 21, 2020 08:06
@eupn eupn requested a review from TheZoq2 January 21, 2020 08:37
@TeXitoi TeXitoi merged commit 8b52514 into stm32-rs:master Jan 21, 2020
@eupn eupn deleted the update-rtfm branch January 21, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Disasm Disasm Disasm left review comments

@TeXitoi TeXitoi TeXitoi approved these changes

@therealprof therealprof Awaiting requested review from therealprof

@TheZoq2 TheZoq2 Awaiting requested review from TheZoq2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eupn @Disasm @TeXitoi