Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/blinky_timer_irq.rs: added an '#[interrupt]' blinky demo #188

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

spicyjack
Copy link

I saw the blinky_timer_irq.rs demo that @therealprof wrote in the stm32f0xx-hal repo and wanted to poke at it, but I only have a Black Pill (STM32F103) board on hand, so...

I ran this command on the example file:

rustfmt --config imports_layout=HorizontalVertical examples/blinky_timer_irq.rs

and I was almost happy with the results, but not quite.

Obligatory animated GIF, since blinkenleds are so exciting...
blinky_timer_irq

Copy link
Contributor

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some super minor comment nits, otherwise looks good (but untested on hardware).

examples/blinky_timer_irq.rs Outdated Show resolved Hide resolved
examples/blinky_timer_irq.rs Outdated Show resolved Hide resolved
examples/blinky_timer_irq.rs Outdated Show resolved Hide resolved
@spicyjack
Copy link
Author

@jamwaffles I've made the capitalization changes

Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting time into adapting this example. LGTM.

@therealprof therealprof merged commit 0cc2262 into stm32-rs:master Feb 20, 2020
@spicyjack spicyjack deleted the blinky_timer_irq branch February 21, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants