Remove generic RCC buses from public API #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I never liked the RccBus generic stuff, as it made it impossible to tell which register to pass to the constructors of functions,
&mut <USART1 as RccBus>::Busisn't very helpful.This PR goes back to explicit APB1 and APB2 in the constructors, but keeps the generic structs inside functions to still provide most of the benefit while improving doc readbility.
While this is a public API change, I don't believe it is breaking, as it still requires the exact same types to be passed to functions.
cc: @burrbull