Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serial changes v3 #417

Merged
merged 9 commits into from
Mar 10, 2022
Merged

Serial changes v3 #417

merged 9 commits into from
Mar 10, 2022

Conversation

AndreySmirnov81
Copy link
Contributor

Breaking changes

  • Passing the Clock parameter to Serial by reference.
  • Serial::usart1/2/3 -> Serial::new.
  • Serial implements Write<WORD> and Read<WORD> for WORD simultaneously as u8 and u16.

Added

  • Allow access to the Tx and Rx parts of the Serial without the need for splitting.
  • Allow Serial reconfiguration by references to the Tx and Rx parts.
  • Allow Serial release after splitting.

Instead of #414 and #409.

@AndreySmirnov81
Copy link
Contributor Author

@burrbull, please review and merge
(the changes are equivalent to pr #414 but do not contain "garbage" commits)

@burrbull
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 10, 2022

Build succeeded:

@bors bors bot merged commit 470cd83 into stm32-rs:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burrbull burrbull burrbull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreySmirnov81 @burrbull