Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fmt::Write for serial Tx #49

Merged
merged 2 commits into from
Mar 19, 2019
Merged

feat: fmt::Write for serial Tx #49

merged 2 commits into from
Mar 19, 2019

Conversation

fmckeogh
Copy link
Contributor

Closes #18, all credit to @therealprof.

therealprof
therealprof requested changes Mar 19, 2019
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to CHANGELOG.md

@fmckeogh
Copy link
Contributor Author

Done.

@TheZoq2
Copy link
Member

TheZoq2 commented Mar 19, 2019

Thanks, though it looks like you added it to 0.2.1 which has already been released. It should be under the unreleased section instead :)

@fmckeogh
Copy link
Contributor Author

🤦‍♂️ My bad, fixed

@therealprof
Copy link
Member

@Chocol4te There's still a merge conflict.

@fmckeogh
Copy link
Contributor Author

Rebased :)

therealprof
therealprof approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@therealprof therealprof merged commit d66f170 into stm32-rs:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmckeogh @TheZoq2 @therealprof