digital v2

[burrbull]

No description provided.

[TheZoq2]

Thanks for the PR! If I understand this correctly, all an end user has to do to use this version with a v1 driver is what's done in examples/mfrc522.rs? Perhaps it would be a good idea to add that to the docs to make things less confusing for new users.

Apart from that, and the note about the never type, I'd say this looks good to merge

[TheZoq2]

I think I read somewhere that the prefered error type for a non-failable pin is ! rather than (). Though the never type isn't fully implemented iirc

[burrbull]

Perhaps it would be a good idea to add that to the docs to make things less confusing for new users.

My English not good enough to write documentation.

[TheZoq2]

My English not good enough to write documentation.

No problem. I was thinking something like this

Interfacing with v1 traits

embedded-hal has two versions of the digital traits, v2 which is used by this crate and v1 which is deprecated but still used by a lot of drivers. If you want to use such a driver with this crate, you need to convert the digital pins to the v1 type.

This is done using embedded-hal::digital::v1_compat::OldOutputPin. For example:

let nss = gpioa.pa4.into_push_pull_output(&mut gpioa.crl);
let mut mfrc522 = Mfrc522::new(spi, OldOutputPin::from(nss)).unwrap();

[burrbull]

Do I need to add this in README or only in docs?

[TheZoq2]

Docs should be enough I think

[TeXitoi]

Maybe using the void crate for the error instead of ()?

[TheZoq2]

Yea, that might not be a bad idea, especially since we already depend on it.

What are the problems with using ! here?

[TeXitoi]

I think ! is not usable at this position on stable.

[burrbull]

Done. Rebased.

[TheZoq2]

I think it might be better to put the new docs in the digital module since that's probably where people will look when they run into issues

[burrbull]

What digital module you mean? gpio maybe?

[TheZoq2]

Yes

[burrbull]

Done.

[geomatsi]

Is there any reason why this snippet differs from all the other places ?
Why not the same here:

self.is_low().map(|b| !b)

[burrbull]

Fixed.

[geomatsi]

LGTM, thanks !

[TheZoq2]

It looks like examples/blinky_rtc.rs is missing unwrap, but other than that, this looks good to merge

[burrbull]

Fixed.

[TheZoq2]

Perfect, thanks!