-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto generate memory.x #216
Conversation
575c747
to
6ceef20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like, that the current memory.x
file is removed now. It was only added to be able to build examples, but was not intended to be used by the user. Having the ld
feature for an opt in correct memory.x
files is the correct way to go, IMO 👍
I guess this feature is worth a mention in the CHANGELOG.md? :)
da41e56
to
908e64c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much appreciate the documentation updates and moving the device-selected check towards the build.rs file is a good solution as well! :)
Nice work. Resolving the commented out devices in CI and after that, this looks good to be merged.
I was thinking about maybe adding the But I think, this is a discussion for later. Let's first release a version with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If you don't say otherwise, I would merge it :)
This PR adds
ld
feature, which enables thememory.x
generation and prevent issues like #215.