-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generic IntoAf #308
generic IntoAf #308
Conversation
This looks really cool. Leveraging type inference to save time looking up the correct alternate function number is a great ergonomic boom! 🎉 I'll have a deeper look later this weekend (hopefully sometime today) but at first glance this looks good |
7db6509
to
d40d2dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really looks like straight forward changes and a good improvement overall. Feel free to add the #[deprecated]
. It might also be ok to remove the old into_af_...
functions, but this could also wait for another release.
Thank you very much!
#[derive(Debug)] | ||
#[cfg_attr(feature = "defmt", derive(defmt::Format))] | ||
pub struct $Gpiox; | ||
#[doc = concat!("GPIO port ", stringify!($GPIOX), " (type state)")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I assume this is the reason for the MSRV 1.52 -> 1.54 bump? Good to decrease the invocations of paste
.
rebased |
LGTM. Thank you very much! |
No description provided.