Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce smoltcp dependency features to a minimum #168

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Reduce smoltcp dependency features to a minimum #168

merged 1 commit into from
Nov 12, 2020

Conversation

richardeoin
Copy link
Member

Since Dependencies are resolved with the union of all features enabled on them, it's good practice to remove unnecessary dependencies.

More features are added by the dev-dependency so that the examples build

@richardeoin
Reduce smoltcp dependency features to a minimum
654c967 
More features are added by the dev-dependency so that the examples build
hargoniX
hargoniX approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@hargoniX hargoniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it compiles it works xD.

@hargoniX
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 12, 2020

Build succeeded:

@bors bors bot merged commit 9426c3f into stm32-rs:master Nov 12, 2020
@richardeoin richardeoin deleted the ethernet-tidy-smol-feat branch December 12, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hargoniX hargoniX hargoniX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardeoin @hargoniX