Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[must_use] annotations #325

Merged
merged 3 commits into from
Apr 2, 2022
Merged

Add #[must_use] annotations #325

merged 3 commits into from
Apr 2, 2022

Commits on Apr 2, 2022

  1. Annotate methods with #[must_use] 

    Use of this attribute was [expanded in the standard
library](https://blog.rust-lang.org/2022/01/13/Rust-1.58.0.html#more-must_use-in-the-standard-library)
in Rust 1.58, there is now a [clippy
lint](https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use)

Silence the lint for REC methods, since dropping the REC is intended

Also silence the lint for GPIO modifiers (set_speed) since these are also often dropped
    @richardeoin
    richardeoin committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    09fc365 View commit details
    Browse the repository at this point in the history

  2. Include REC in free method for qei

    @richardeoin
    richardeoin committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    54f0bbb View commit details
    Browse the repository at this point in the history

  3. Add more documentation for REC objects and highlight where they are d… 

    …ropped
    @richardeoin
    richardeoin committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    f907bbe View commit details
    Browse the repository at this point in the history