Revert back DMA API to StableDeref #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be ready for review/merge now. |
|
Lets just wait for @MabezDev to have time to review this :) |
|
Interesting, is there somewhere I can read the discussion as to why it was unsound? Either way, LGTM! |
|
@MabezDev Most of the discussion was in the matrix chat, but this kinda sums it up: And also, see this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #94 I suggested that there wasn't a need for
StableDerefif we had'static. I was wrong, right now the DMA API is unsound. This PR reverts back toStableDeref.Blocked on rust-embedded/heapless#148