Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build options in source comments #1408

Closed
wants to merge 1 commit into from
Closed

build options in source comments #1408

wants to merge 1 commit into from

Conversation

koendv
Copy link

@koendv koendv commented Jun 3, 2021

This PR allows embedding build options in project .ino source comments, like this:

// build-opt -DUSB_PRODUCT_STRING=\"device\ name\"

void setup() {
  // put your setup code here, to run once:
}

void loop() {
  // put your main code here, to run repeatedly:
}

This way there is no need for a separate build_opt.h file. This also works when using arduino ide 2.0.0.

@fpistm fpistm added the waiting feedback Further information is required label Jun 3, 2021
@fpistm
Copy link
Member

fpistm commented Jun 3, 2021

Hi @koendv
thanks for this proposal.
At this time I will not merge this as I'd like to have Arduino feedback about arduino/arduino-ide#363 arduino/arduino-cli#1338

@fpistm
Copy link
Member

fpistm commented Jul 12, 2021

Hi @koendv
Thanks for this PR, it was a great idea anyway I will not merge them.

When Arduino will fix the original issue then I will review this part moreover Arduino study/implement a way to "Provide dedicated sets of "extra flags" properties for platform developers and users"
arduino/arduino-cli#846

@fpistm fpistm closed this Jul 12, 2021
@fpistm fpistm added abandoned No more work on this and removed waiting feedback Further information is required labels Jul 12, 2021
@fpistm fpistm added wontfix This will not be worked on and removed On hold labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned No more work on this wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants