Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): setTimeout shadows Stream.setTimeout #74

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Sep 28, 2023

Rename it setConnectionTimeout to match Arduino Ethernet API.

https://www.arduino.cc/reference/en/libraries/ethernet/client.setconnectiontimeout/

Fixes #72

Rename it setConnectionTimeout to match Arduino Ethernet API.

Fixes stm32duino#72

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm added the enhancement New feature or request label Sep 28, 2023
@fpistm fpistm added this to the 1.3.1 milestone Sep 28, 2023
@fpistm fpistm merged commit 60bbf39 into stm32duino:main Sep 29, 2023
3 checks passed
@fpistm fpistm deleted the setConnectionTimeout branch September 29, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

EthernetClient.setTimeout shadows Stream.setTimeout
1 participant