Subscription replace should annotate the objects like a normal subscription. #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokej
changed the title
ianzhang366
approved these changes
Sep 23, 2020
xiangjingli
approved these changes
Sep 23, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ianzhang366, rokej, xiangjingli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed!
|
magic-mirror-bot bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
Includes the fields for policy ordering. Refs: - stolostron/backlog#26906 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 6cb8361)
magic-mirror-bot bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
Includes the fields for policy ordering. Refs: - https://github.com/stolostron/backlog/issues/26906 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 6cb8361)
dhaiducek
pushed a commit
to dhaiducek/multicloud-operators-subscription
that referenced
this pull request
Oct 17, 2024
Includes the fields for policy ordering. Refs: - stolostron/backlog#26906 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/open-cluster-management/backlog/issues/5623
If subscription-admin chooses
mergeoption to update existing resources not owned by subscription, remove the typical annotations subscription controller adds. This will avoid the resources being deleted when the subscription is removed.If subscription-admin chooses
replaceoption to update existing resources not owned by subscription, keep the typical annotations subscription controller adds. Subscription takes over the resources. When the subscription is removed, the resources will be removed too.