Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase default client side QPS #387

Merged
merged 3 commits into from
Dec 17, 2020
Merged

increase default client side QPS #387

merged 3 commits into from
Dec 17, 2020

Conversation

ianzhang366
Copy link
Contributor

From the most recent performance test, the suggestion from Hao Liu, and some other
projects, it seems the default QPS, which is 5, is a bit too small.

Reference:
https://github.com/open-cluster-management/registration/pull/95/
voyagermesh/voyager#640 (comment)

@ianzhang366 ianzhang366 requested review from rokej and removed request for hirokuni-kitahara December 17, 2020 15:10
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ianzhang366, rokej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Dec 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ianzhang366 ianzhang366 merged commit 1bd7dc3 into master Dec 17, 2020
@ianzhang366 ianzhang366 deleted the increase-default-qps branch December 17, 2020 17:20
magic-mirror-bot bot pushed a commit that referenced this pull request Feb 7, 2024
ref: https://issues.redhat.com/browse/ACM-9060

Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
(cherry picked from commit 766d357)
magic-mirror-bot bot pushed a commit that referenced this pull request Feb 7, 2024
ref: https://issues.redhat.com/browse/ACM-9060

Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
(cherry picked from commit 766d357)
dhaiducek added a commit to dhaiducek/multicloud-operators-subscription that referenced this pull request Oct 17, 2024
ref: https://issues.redhat.com/browse/ACM-9060

Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants