Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Sync from open-cluster-management-io/multicloud-operators-subscription: #343 #974

Merged
merged 1 commit into from
Jun 5, 2023
Merged

🤖 Sync from open-cluster-management-io/multicloud-operators-subscription: #343 #974

merged 1 commit into from
Jun 5, 2023

Conversation

magic-mirror-bot[bot]
Copy link
Contributor

@philipwu08
Update clusterrole to support managedserviceaccounts for gitopscluste…
753242f 
…r controller (#343)

Signed-off-by: philipwu08 <phwu@redhat.com>
(cherry picked from commit 2b945eb)
@openshift-ci openshift-ci bot requested review from chenz4027 and rokej June 5, 2023 20:04
@openshift-ci
Copy link

openshift-ci bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign jnpacker for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magic-mirror-bot magic-mirror-bot bot merged commit 590fee5 into main Jun 5, 2023
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1685995429975 branch June 5, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenz4027 chenz4027 Awaiting requested review from chenz4027

@rokej rokej Awaiting requested review from rokej

Assignees
No one assigned
Labels
dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@philipwu08