fix: set proper document source if legacy parsed result is given #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billiegoose
approved these changes
Mar 29, 2020
nulltoken
reviewed
Mar 30, 2020
| @@ -72,7 +72,7 @@ export class Spectral { | |||
| opts.resolve?.documentUri, | |||
| ); | |||
|
|
|||
| if (document.source === void 0 && opts.resolve?.documentUri !== void 0) { | |||
| if (document.source === null && opts.resolve?.documentUri !== void 0) { | |||
There was a problem hiding this comment.
@P0lip That changes looks strange, unrelated to the gist of this PR.
Considering the code of normalizeSource() is
const normalizeSource = (source: Optional<string>): string | null => {
if (source === void 0) return null;
return source && !startsWithProtocol(source) ? normalize(source) : source;
};
I wonder, are we also fixing an existing bug? Shouldn't this deserve a slight test?
There was a problem hiding this comment.
So actually it's not a bug. The typings are correct, but for whatever reason ts didn't complain about it.
Source can either be null or string, not undefined, so the condition was simply wrong.
There was a problem hiding this comment.
The typings are correct, but for whatever reason ts didn't complain about it.
Weird... 👍
nulltoken
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by Studio 😁
A tiny bug, shouldn't really affect anyone besides Studio.
Checklist
Does this PR introduce a breaking change?