fix: make example-value-or-externalValue only target oas3 document
#1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example has been taken from the initial `example-value-or-externalValue` definition in the ruleset. The rule has since been updated but this doco example hasn't. Let's make the doco example a litlle less dependent on the concrete rule implementation. It's sole purpose is to provide a sample usage of the `xor`function.
P0lip
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Both code and documentation changes look good to me.
Might be good to have @philsturgeon's pair of eyes on this one, as he's by far more familiar with OpenAPI than I am.
philsturgeon
approved these changes
Apr 6, 2020
P0lip
changed the title
example-value-or-externalValue only target oas3 documentexample-value-or-externalValue only target oas3 document
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #883.
Checklist
Does this PR introduce a breaking change?
This results in a change in the OAS3 ruleset content (one rule removed and one rule added).
As a side addition, the
xorfunction documentation has (tentatively) been updated to make it more clear with regards toallowedvsrequired.