perf: improve ruleset loading #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
perf/ruleset-validation
branch
from
4c38133 to
f7b0331
Compare
P0lip
commented
May 29, 2020
| @@ -15,6 +15,14 @@ export interface IRulesetReadOptions { | |||
| timeout?: number; | |||
| } | |||
|
|
|||
| function parseContent(content: string, source: string): unknown { | |||
| if (extname(source) === '.json') { | |||
There was a problem hiding this comment.
stoplight/path#extname handles URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copyRuleunnecessarily performs a deep clone that is expensive at times due to the presence of oas2 & oas3 JSON Schema that need to be copied over.We can perform a shallow copy here, as we do not alter the value of
functionOptionswhile merging rules.thenis mutated however here, so we need to account for this.Checklist
Does this PR introduce a breaking change?
Screenshots
Before:
After:
zoomed in :P
If applicable, add screenshots or gifs to help demonstrate the changes. If not applicable, remove this screenshots section before creating the PR.
Additional context
Not a big deal in case of CLI users, but fairly important for Studio users, as the Spectral activation is slower than it has to be.
Bonus change - we prefer
JSON.parsewhen the filepath has.jsonextension or the url's pathname ends with.json.Last but not least - a couple of ESLint warnings addressed.