feat: use @stoplight/better-ajv-errors #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nulltoken
reviewed
Jun 18, 2020
| @@ -106,7 +106,7 @@ describe(`Rule '${ruleName}'`, () => { | |||
| expect(results).toEqual([ | |||
| expect.objectContaining({ | |||
| code: ruleName, | |||
| message: 'Object should have required property `value`', | |||
| message: '`1` property should have required property `value`', | |||
There was a problem hiding this comment.
@P0lip This dependency change brings very interesting results messages. I actually never noticed the Object should have requi... pattern before.
should be relatively cheap, given the fact the upstream package isn't very active. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1223 #455
Note - I'm going to publish
@stoplight/better-ajv-errorsto npm, so the git url is temporary.Checklist
Does this PR introduce a breaking change?