Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ruleset): introduce documentationUrl property #1242

Merged
merged 13 commits into from
Jul 10, 2020

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Jun 22, 2020

Related to https://github.com/stoplightio/studio/issues/445

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added the enhancement New feature or request label Jun 22, 2020
@P0lip P0lip requested review from philsturgeon and nulltoken June 22, 2020 14:27
@P0lip P0lip self-assigned this Jun 22, 2020
Copy link
Contributor

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it when those changes have been done. Thank you for adding this!

@nulltoken
Copy link
Contributor

@P0lip Neat!

P0lip and others added 5 commits June 22, 2020 19:49
@P0lip P0lip requested a review from philsturgeon June 22, 2020 21:54
Co-authored-by: nulltoken <emeric.fermas@gmail.com>
@P0lip P0lip requested a review from nulltoken June 23, 2020 12:50
@P0lip P0lip force-pushed the feat/documentation-url-ruleset branch from 297cc9f to b166c92 Compare June 23, 2020 12:50
philsturgeon
philsturgeon previously approved these changes Jul 8, 2020
Copy link
Contributor

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! :D

@P0lip
Copy link
Contributor Author

P0lip commented Jul 9, 2020

One last review 😆 hopefully.
@philsturgeon just hit merge once you approve

@P0lip P0lip merged commit fb08bee into develop Jul 10, 2020
@P0lip P0lip deleted the feat/documentation-url-ruleset branch July 10, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants