fix: casing fn handles leading char #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nulltoken
reviewed
Jun 25, 2020
src/functions/casing.ts
Outdated
| targetVal.length === 1 && | ||
| opts.separator !== void 0 && | ||
| opts.separator.allowLeading === true && | ||
| targetVal.endsWith(opts.separator.char) |
There was a problem hiding this comment.
@P0lip endsWith seems a bit "weird" to me here especially when targetVal length == 1
There was a problem hiding this comment.
this is due to eslint rule.
I can change it to targetVal[0] and disable the rule for this particular line, because it indeed feels weird
nulltoken
reviewed
Jun 25, 2020
src/functions/casing.ts
Outdated
| opts.separator !== void 0 && | ||
| opts.separator.allowLeading === true && | ||
| // eslint-disable-next-line @typescript-eslint/prefer-string-starts-ends-with | ||
| targetVal[0] === opts.separator.char |
There was a problem hiding this comment.
@P0lip There might be something I don't understand (and in that case I apologize in advance for being that thick), but we know targetVal is one char long, we also know the separator is also one char long (enforced through schema rule). Can't we just compare them directly (ie. targetVal === opts.separator.char)?
There was a problem hiding this comment.
well, yeah, foolish me 🤦♂️
P0lip
commented
Jun 25, 2020
nulltoken
reviewed
Jun 26, 2020
Co-authored-by: nulltoken <emeric.fermas@gmail.com>
nulltoken
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could tweak the regular expression, but this feels more readable to me.
Checklist
Does this PR introduce a breaking change?