feat(oas): validate 'default' in schemas #1429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1402
Checklist
Does this PR introduce a breaking change?
Additional context
I'm very torn when it comes to the solution chosen here.
Besides what's implemented here, I considered the following:
oas2-valid-schema-default
andoas3-valid-schema-default
- this might cause redundant fragmentationoas2-valid-schema
(wouldn't it be confusing, though?) - this one would be breaking and therefore defer the release of the fixI still think that ideally we should rename the rules, so that we can validate more things in the future using the same rule.
I'm not fully certain, however, so hm... @philsturgeon ideas?