Add rule to detect duplicated entry in enum #1485
Conversation
|
@P0lip To make the repository properly worked on my computer, I've followed the instruction on your great documentation CONTRIBUTING but I've faced an issue that I resolved updating the file karma.conf.ts in the following manner: - browsers: ['ChromeHeadless'],
+ browsers: ['ChromeHeadlessNoSandbox'],
+
+ customLaunchers: {
+ ChromeHeadlessNoSandbox: {
+ base: 'ChromeHeadless',
+ flags: ['--no-sandbox']
+ }
+ },
``
Would you like me to also push this update? |
Amachua
force-pushed
the
vidalqu/rules/check-duplicated-enum
branch
3 times, most recently
from
852092b to
3c8921f
Compare
|
Amazing work, thank you! |
Amachua
force-pushed
the
vidalqu/rules/check-duplicated-enum
branch
from
7a82f16 to
99a1576
Compare
| @@ -397,6 +397,44 @@ TheBadModel: | |||
| - 8 | |||
| ``` | |||
|
|
|||
| ### duplicated-entry-in-enum | |||
There was a problem hiding this comment.
@philsturgeon While reviewing the file I've sent, I saw that I didn't sent the right sample on this file --> Updated with good samples :)
| @@ -0,0 +1,33 @@ | |||
| ====test==== | |||
| Identify enum values that does not respect the specified type | |||
There was a problem hiding this comment.
| Identify enum values that does not respect the specified type | |
| Identify non-unique enum values |
There was a problem hiding this comment.
Ah, oops. Missed it. Going to keep that in mind and will include your suggestion in some other PR.
|
If that config change helps then please do. |
|
@Amachua what was the error you had? Are you on Linux? |
|
I'll merge the PR in the meantime. LMK what that error was exactly about, so that we can evaluate the options. |
|
This rule is too simple and should be fixed, see #1571 |
Fixes #1478 .
Checklist
Does this PR introduce a breaking change?