Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve paths lookup #413

Merged
merged 1 commit into from
Jul 31, 2019
Merged

perf: improve paths lookup #413

merged 1 commit into from
Jul 31, 2019

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Jul 31, 2019

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

paths is a top-level property, so there is no reason to perform a deep scanning, which is utterly slow for larger specs.

Copy link
Contributor

@XVincentX XVincentX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is perf a valid semantic release prefix? What kind of release will it trigger?

@philsturgeon
Copy link
Contributor

We don’t use semantic release for spectral :)

@XVincentX XVincentX merged commit 390eba8 into develop Jul 31, 2019
@marbemac marbemac deleted the fix/improve-path-lookup branch July 31, 2019 15:09
philsturgeon pushed a commit that referenced this pull request Jul 31, 2019
philsturgeon pushed a commit that referenced this pull request Jul 31, 2019
* perf: improve paths lookup (#413)

* chore: prepping v4.0.2
philsturgeon pushed a commit that referenced this pull request Aug 8, 2019
philsturgeon pushed a commit that referenced this pull request Aug 20, 2019
* perf: improve paths lookup (#413)

* chore: prepping v4.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants