Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: YAML 1.2 #499

Merged
merged 3 commits into from
Aug 28, 2019
Merged

feat: YAML 1.2 #499

merged 3 commits into from
Aug 28, 2019

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Aug 28, 2019

Closes #481

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added the enhancement New feature or request label Aug 28, 2019
@P0lip P0lip added this to the Aug '19 Hardening milestone Aug 28, 2019
@P0lip P0lip requested a review from philsturgeon August 28, 2019 14:57
@P0lip P0lip self-assigned this Aug 28, 2019

const implicitStringOAS3Document = path.join(__dirname, './__fixtures__/implicit-strings.oas3.yaml');

describe('Parsing', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have exactly the same test case in yaml repo, but having it here won't hurt.

@P0lip
Copy link
Contributor Author

P0lip commented Aug 28, 2019

I'll cherry-pick it to 4.1 release branch once merged

@P0lip P0lip merged commit 492ad42 into develop Aug 28, 2019
@P0lip P0lip deleted the feat/yaml-1point2 branch August 28, 2019 15:14
P0lip added a commit that referenced this pull request Aug 28, 2019
* feat: YAML 1.2

* docs(js): syntax error

* test: rename case
P0lip added a commit that referenced this pull request Aug 29, 2019
* feat: YAML 1.2

* docs(js): syntax error

* test: rename case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spectral doesn't seem to properly honor %YAML directive
2 participants