Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce json-schema format #575

Merged
merged 10 commits into from
Sep 20, 2019
Merged

feat: introduce json-schema format #575

merged 10 commits into from
Sep 20, 2019

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Sep 19, 2019 •
edited
Loading

Closes #571

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Additional context

@P0lip P0lip self-assigned this Sep 19, 2019
@P0lip P0lip force-pushed the feat/json-schema-formats branch from baab45d to 2e8096c Compare September 19, 2019 22:03
@P0lip P0lip marked this pull request as ready for review September 19, 2019 22:03
@P0lip P0lip added the enhancement New feature or request label Sep 19, 2019
@P0lip P0lip requested a review from philsturgeon September 19, 2019 22:04
@P0lip P0lip requested a review from marbemac September 19, 2019 22:07
@marbemac
Copy link
Contributor

Looks great, nice work. These lookup / format checkers are quite helpful from a library user perspective (and we could probably use them in studio) - should we export a portion of that stuff from the root package?

@P0lip
Copy link
Contributor Author

P0lip commented Sep 19, 2019 •
edited
Loading

@marbemac
Yeah, that's a valid point. Done.
Right now, I simply use full paths, like @stoplight/spectral/dist/lookups/openapi, but this breaks anytime we decide to move the file.

@P0lip P0lip merged commit 5ff72b5 into develop Sep 20, 2019
@P0lip P0lip deleted the feat/json-schema-formats branch September 20, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philsturgeon philsturgeon philsturgeon approved these changes

@marbemac marbemac Awaiting requested review from marbemac

Assignees

@P0lip P0lip

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create rule format for JSON schema files
3 participants
@P0lip @marbemac @philsturgeon