feat: static assets #671
feat: static assets #671
Conversation
P0lip
force-pushed
the
feat/assets
branch
2 times, most recently
from
3b61339 to
8762a87
Compare
| const target = path.join(baseDir, `assets.json`); | ||
| const assets = {}; | ||
|
|
||
| (async () => { |
There was a problem hiding this comment.
Is this change needed if we are doing #561 ?
There was a problem hiding this comment.
Yeah, it's still going to be needed. It's mostly for Studio to use and we don't expose it anywhere in the docs, etc.
I'll leave a note somewhere in the code on what it actually does and how it works, as right now it's not obvious, and we will forget about why we need it.
I see Windows build is failing, so need to take a look what's broken.
There was a problem hiding this comment.
@collinbachi did we already switch to whatever new CircleCI payment structure that gets us Windows builds?
There was a problem hiding this comment.
We started a 2 week trial of the new structure Wednesday afternoon
There was a problem hiding this comment.
@P0lip ok, fair enough on the still needed. If you cannot get windows build working with Azure then maybe try out the CircleCI windows build, however that works.
There was a problem hiding this comment.
@philsturgeon I got Windows build working, but would love to try out Windows on CircleCI. Azure pipelines is tad slow.
This reverts commit b7d235d112efe4a19279433992b0765e8bf89cdd.
Change driven by Studio.
Will describe it in a great detail soon, once it's ready to review.Long story short - Studio will provide its own assets in the following manner