Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: report invalid YAML mapping keys #840

Merged
merged 4 commits into from
Dec 10, 2019
Merged

feat: report invalid YAML mapping keys #840

merged 4 commits into from
Dec 10, 2019

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Dec 9, 2019

Closes #726

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added the enhancement New feature or request label Dec 9, 2019
@P0lip P0lip requested a review from philsturgeon December 9, 2019 11:42
@P0lip P0lip self-assigned this Dec 9, 2019
philsturgeon
philsturgeon previously approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. This looks a little more friendly than how Swagger Editor handles the same situation.

Screen Shot 2019-12-09 at 17 02 06

@P0lip P0lip merged commit a86a163 into develop Dec 10, 2019
@P0lip P0lip deleted the feat/invalid-mappings branch December 10, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philsturgeon philsturgeon philsturgeon approved these changes

Assignees

@P0lip P0lip

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema Function Not Working with @key
2 participants
@P0lip @philsturgeon