Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate mapping keys #33

Merged
merged 4 commits into from
Dec 9, 2019
Merged

feat: validate mapping keys #33

merged 4 commits into from
Dec 9, 2019

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Nov 29, 2019

@P0lip P0lip added the enhancement New feature or request label Nov 29, 2019
@P0lip P0lip requested a review from marbemac November 29, 2019 14:32
@P0lip P0lip self-assigned this Nov 29, 2019
@P0lip P0lip requested a review from marbemac December 3, 2019 14:32
@marbemac
Copy link
Contributor

marbemac commented Dec 4, 2019

Omg I totally misread the code and your comment. If we're just parsing yaml for yaml's sake (without the JSON option), not sure we want to all all the noise of the hints/warnings - might just get noisy, what do you think? Sorry about that.

@P0lip
Copy link
Contributor Author

P0lip commented Dec 4, 2019

If we're just parsing yaml for yaml's sake (without the JSON option), not sure we want to all all the noise of the hints/warnings - might just get noisy, what do you think?

Well, that was my thought too. It'd get noisy for no strong reason, since one may still simply want to consume AST.

@P0lip
Copy link
Contributor Author

P0lip commented Dec 5, 2019

@marbemac should be ready to go

@P0lip P0lip merged commit 2712bee into master Dec 9, 2019
@P0lip P0lip deleted the feat/mapping-keys branch December 9, 2019 08:08
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema Function Not Working with @key
3 participants