fix: uniform response for malicious content (#110)

This PR uniforms response for malicious content to become like other IPFS Gateways
storacha · Mar 8, 2023 · 762982a · 762982a
1 parent b5bb88e
commit 762982a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/.github/workflows/cid-verifier.yml b/.github/workflows/cid-verifier.yml
@@ -57,8 +57,6 @@ jobs:
         with:
           node-version: 16
           cache: 'pnpm'
-        with:
-          cache: 'pnpm'
       - run: pnpm install
       - name: Publish app
         uses: cloudflare/wrangler-action@2.0.0
@@ -100,9 +98,8 @@ jobs:
           version: 7
       - uses: actions/setup-node@v3
         with:
-          cache: 'pnpm'
           node-version: 16
-          registry-url: 'https://registry.npmjs.org'
+          cache: 'pnpm'
       - run: pnpm install
       - name: Deploy
         uses: cloudflare/wrangler-action@2.0.0

diff --git a/packages/cid-verifier/src/verification.js b/packages/cid-verifier/src/verification.js
@@ -42,7 +42,7 @@ export const verificationGet = withCidPathParam(
   async function (cid, request, env) {
     const threats = await getStoredThreats(cid, env)
     if (threats?.length) {
-      return new Response(threats.join(', '), { status: 403 })
+      return new Response(null, { status: 403 })
     }
 
     return new Response('', { status: 204 })

diff --git a/packages/cid-verifier/test/verification.spec.js b/packages/cid-verifier/test/verification.spec.js
@@ -78,7 +78,6 @@ test('GET /:cid handles successful results', async (t) => {
 test('GET /:cid handles malware cid', async (t) => {
   const { mf } = t.context
   const response = await mf.dispatchFetch(`http://localhost:8787/${malwareCid}`, { headers })
-  t.is(await response.text(), 'MALWARE')
   t.is(response.status, 403)
 })