fix: stricter requirements for cache #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
force-pushed
the
fix/stricter-reqs-for-cache2
branch
from
05764c4
to
4f656da
Compare
This was referenced Sep 20, 2024
alanshaw
pushed a commit
that referenced
this pull request
Sep 25, 2024
🤖 I have created a release *beep* *boop* --- ## [1.13.0](edge-gateway-v1.12.1...edge-gateway-v1.13.0) (2024-09-25) ### Features * use big file downloader ([#180](#180)) ([57832cc](57832cc)) ### Fixes * maybe do not use path ([070abcf](070abcf)) * org slug ([65b8494](65b8494)) * remove unused env var ([177ac95](177ac95)) * stricter requirements for cache ([#178](#178)) ([3dc5c15](3dc5c15)) * use bootstrap sha ([05182c6](05182c6)) ### Other Changes * trigger release ([c05de73](c05de73)) * trigger release ([3661323](3661323)) * update repo ([#179](#179)) ([1d99326](1d99326)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the requirements for adding to the cache stricter and in accordance with the cloudflare docs.
We only call
waitUntilif it is possible for the response to be added to the cache. This should reduce errors and potentially worker runtimes.