-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use big file downloader #180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
force-pushed
the
feat/big-file-downloader
branch
from
September 23, 2024 11:22
5b13727
to
7c56c25
Compare
fforbeck
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. I just added a minor comment about one of the comparisons with null
.
@@ -0,0 +1,4 @@ | |||
exports.bigData = { | |||
cid: 'bafybeihctj26zx2smrvl6ev7k2h4krjey3rd2irjsqtduhlowwe75fdzo4', | |||
bytes: new TextEncoder().encode('Hello w3s.link!!!!!!'.repeat(10_000_000)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
alanshaw
force-pushed
the
feat/big-file-downloader
branch
from
September 25, 2024 08:11
53ff76e
to
2141b97
Compare
This was referenced Sep 20, 2024
alanshaw
pushed a commit
that referenced
this pull request
Sep 25, 2024
🤖 I have created a release *beep* *boop* --- ## [1.6.0](ipfs-gateway-race-v1.5.0...ipfs-gateway-race-v1.6.0) (2024-09-25) ### Features * use big file downloader ([#180](#180)) ([57832cc](57832cc)) ### Fixes * maybe do not use path ([070abcf](070abcf)) * use bootstrap sha ([05182c6](05182c6)) ### Other Changes * trigger release ([c05de73](c05de73)) * trigger release ([3661323](3661323)) * update repo ([#179](#179)) ([1d99326](1d99326)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alanshaw
pushed a commit
that referenced
this pull request
Sep 25, 2024
🤖 I have created a release *beep* *boop* --- ## [1.13.0](edge-gateway-v1.12.1...edge-gateway-v1.13.0) (2024-09-25) ### Features * use big file downloader ([#180](#180)) ([57832cc](57832cc)) ### Fixes * maybe do not use path ([070abcf](070abcf)) * org slug ([65b8494](65b8494)) * remove unused env var ([177ac95](177ac95)) * stricter requirements for cache ([#178](#178)) ([3dc5c15](3dc5c15)) * use bootstrap sha ([05182c6](05182c6)) ### Other Changes * trigger release ([c05de73](c05de73)) * trigger release ([3661323](3661323)) * update repo ([#179](#179)) ([1d99326](1d99326)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
@storacha/unixfs-dl
to make ranged requests to big unixfs files in order to not exhaust the upstream worker of CPU time.Also switches to using the
Link
type for CIDs instead ofstring
. This allows us to detect if the CID is using the "raw" IPLD codec.