Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add support for embedded effects #347

Merged
merged 2 commits into from
Apr 4, 2024
Merged

feat!: add support for embedded effects #347

merged 2 commits into from
Apr 4, 2024

Conversation

Gozala
Copy link
Collaborator

@Gozala Gozala commented Apr 3, 2024

Adds changes to support embedding effects into receipts. Behavior is similar to the way proofs work in the delegations. If you pass an invocation it will be embedded in a agent message, if you pass link to invocation no invocation will be embedded.

Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✨ thanks for putting this together

@vasco-santos
Copy link
Contributor

I am merging and releasing it to integrate on my PRs

@vasco-santos vasco-santos merged commit 58f7c13 into main Apr 4, 2024
47 checks passed
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@vasco-santos vasco-santos deleted the feat/embed-fx branch April 4, 2024 09:58
Peeja added a commit to storacha/console that referenced this pull request Oct 22, 2024
[Ucanto 10 added support for embedded
effects.](storacha/ucanto#347) That's why
uploads have been failing: we're still on 9 in some places.

The whole way we load things here needs an overhaul: we have multiple
instances of some packages where it only makes sense to have one, and to
piece things together as peer dependencies. But that's a huge thing to
solve, so for now, brute force it by just making sure everything is up
to date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants