fix: listen for any object_created event on carpark bucket #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we COPY cars into carpark from pickup as we first put them to a staging bucket before validating them. listening for only the `object_created_put` event means copy events do not trigger indexing. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
View stack outputs
|
alanshaw
approved these changes
Aug 18, 2023
vasco-santos
approved these changes
Aug 29, 2023
|
@olizilla can we merge + release? |
|
I'm back on this tomorrow. This PR should be merged before anything is deployed to prod. If you have time to review and verify it, feel free to merge it today. |
|
Verified. The PR build sets the S3 trigger to be any ObjectCreated event. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we COPY cars into carpark from pickup as we first put them to a staging bucket before validating them.
listening for only the
object_created_putevent means copy events do not trigger indexing.License: MIT