-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: limit max upload size #224
Conversation
969fba0
to
54aa36e
Compare
View stack outputs
|
Also updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I do think however that it might be a good idea to pull in the data-segment lib and use it's functions to derive this number. That way future changes will propagate without us having to find all the places we have calculated the sizes.
I would say this is implementation detail. Other users of data-segment can actually have other limits like 8Gb. I will merge but happy to iterate this further, even though I am not clear on what would mean using |
Adds limit based on previous decisions, considering that S3 Put command has hard-limit of 5GiB.
Closes storacha/w3up#827