fix: aggregate offer invocation cid wrong #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
changed the title
vasco-santos
force-pushed
the
fix/aggregate-offer-invocation-cid-wrong-because-not-pieces-cid-block-being-used-but-buffer-block
branch
from
b88ed5d
to
49ed90f
Compare
…k being used but buffer block
vasco-santos
force-pushed
the
fix/aggregate-offer-invocation-cid-wrong-because-not-pieces-cid-block-being-used-but-buffer-block
branch
from
49ed90f
to
53f7d2e
Compare
vasco-santos
deleted the
fix/aggregate-offer-invocation-cid-wrong-because-not-pieces-cid-block-being-used-but-buffer-block
branch
vasco-santos
pushed a commit
that referenced
this pull request
Nov 3, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.3](filecoin-api-v4.0.2...filecoin-api-v4.0.3) (2023-11-03) ### Bug Fixes * aggregate offer invocation cid wrong ([#1063](#1063)) ([90a5a4d](90a5a4d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
vasco-santos
commented
Nov 3, 2023
| @@ -77,6 +77,7 @@ export const pieceAccept = async ({ capability }, context) => { | |||
| } | |||
| } | |||
|
|
|||
| // Get buffered pieces | |||
There was a problem hiding this comment.
line 88 .pieces now has pieces CID instead of buffer :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because not pieces cid block being used but buffer block, which was meaning a different CID being computed for invocation and receipt, as seen in:
So,
AggregatorRecordnow has a property for buffer and one for pieces.bufferallows us to get to know the pieces inside thebufferwhilepiecesis the direct encoding ofPieceLink[]dag-cbor. We could just rely on the buffer, but for issuing allaggregate/acceptreceipts for each piece, we would need an extra S3 get to read the buffer and compute the dag cbor for the list of pieces inside the buffer