fix: bind globalThis.fetch to globalThis #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
changed the title
travis
added a commit
that referenced
this pull request
Jan 3, 2024
🤖 I have created a release *beep* *boop* --- ## [13.0.0](upload-client-v12.3.2...upload-client-v13.0.0) (2023-12-14) ### ⚠ BREAKING CHANGES * return allocated bytes in `store/add` receipt ([#1213](#1213)) ### Features * dont use ipfs-utils fetch with upload progress by default ([#1240](#1240)) ([86aedbc](86aedbc)) * return allocated bytes in `store/add` receipt ([#1213](#1213)) ([5d52e44](5d52e44)) ### Fixes * bind globalThis.fetch to globalThis ([#1242](#1242)) ([ef59358](ef59358)) * point `main` at files included in the package ([#1241](#1241)) ([c0b306d](c0b306d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the assigned fetch behave a bit differently than a regular
globalThis.fetch. a globalThis.fetch will sometimes fail if you doconst me = { fetch }; await me.fetch(url)but now this bound one won't and will instead behave differently thanglobalThis.fetch.I think the difference in behavior doesn't matter too much because we just use the assigned fetch right away without passing it along or calling it in such a way that we'd change the default behavior of function calling where
thisisglobalThisin a way that allfetchi've encountered can work with.