feat: non-parallel piece hashing and CAR upload #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
approved these changes
Feb 7, 2024
vasco-santos
added a commit
that referenced
this pull request
Mar 21, 2024
🤖 I have created a release *beep* *boop* --- ## [13.1.0](upload-client-v13.0.1...upload-client-v13.1.0) (2024-03-21) ### Features * byo piece hasher ([#1323](#1323)) ([fe2e3d5](fe2e3d5)) * non-parallel piece hashing and CAR upload ([#1305](#1305)) ([7a6385b](7a6385b)) * upgrade ucanto/transport to 9.1.0 in all packages to get more verbose errors from HTTP transport on non-ok response ([#1312](#1312)) ([d6978d7](d6978d7)) ### Fixes * upload client should perform filecoin offer ([#1333](#1333)) ([466e3f7](466e3f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a gut feeling that synchronous piece hashing is causing store requests to timeout, specifically waiting for headers in node.js. I think they are probably sent, but event loop is too busy to actually receive them and a timeout gets triggered.
This PR removes parallelism around generating piece hashes, sending
store/addinvocation and uploading a CAR.refs #1290