fix: filecoin test use blob #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/filecoin-test-use-blob
branch
from
696e7d0
to
44eb674
Compare
vasco-santos
force-pushed
the
fix/filecoin-test-use-blob
branch
from
44eb674
to
462527a
Compare
alanshaw
approved these changes
Apr 30, 2024
packages/filecoin-api/test/utils.js
Outdated
| link: car.cid, | ||
| size: car.size, | ||
| })) | ||
| const blob = new Blob([bytes]) |
There was a problem hiding this comment.
Does it need to be a Blob though?
vasco-santos
force-pushed
the
fix/filecoin-test-use-blob
branch
from
ab3d8de
to
f244828
Compare
This was referenced Apr 30, 2024
vasco-santos
pushed a commit
that referenced
this pull request
Apr 30, 2024
🤖 I have created a release *beep* *boop* --- ## [3.3.3](filecoin-client-v3.3.2...filecoin-client-v3.3.3) (2024-04-30) ### Fixes * filecoin test use blob ([#1422](#1422)) ([359c0b7](359c0b7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vasco-santos
added a commit
that referenced
this pull request
Apr 30, 2024
🤖 I have created a release *beep* *boop* --- ## [6.0.1](filecoin-api-v6.0.0...filecoin-api-v6.0.1) (2024-04-30) ### Fixes * filecoin test use blob ([#1422](#1422)) ([359c0b7](359c0b7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filecoin api exported tests still using CARs instead of Blobs, which means storacha/w3infra#360 need to have TestContentStore to use CARs to make these tests work https://github.com/w3s-project/w3infra/pull/360/files#diff-cd843762832d0767495ff56f3f8692a15262dce245db89690794a1316868e25aR99
But, we want to use Blobs already, so let's make the tests also want Blobs across Filecoin pipeline :)
note that in practise both Blobs and CARs work, but for testing we are only writing one of them and is a CAR today https://github.com/w3s-project/w3up/blob/main/packages/filecoin-api/test/events/storefront.js#L42