-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add blob protocol to upload-client #1425
Merged
Merged
Changes from 36 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
9aee035
feat: add blob add to upload-cli
joaosa 48cde40
feat: use blob add on upload-cli
joaosa d5672c8
feat: modify tests to cover blob add on upload-client
joaosa 0f1e592
chore: cleanup code and add current status
joaosa 1ccb3c4
feat: revamp implementation
joaosa dc40432
chore: cleanup blob/add implementation
joaosa 48a641e
chore: fix typo
joaosa 99c1878
feat: expose blob add result types
joaosa 8ae5f69
fix: have all test return types match the blob add response
joaosa 2ff3748
fix: pass upload CAR and file tests
joaosa 8fb6720
fix: pass upload-client tests
joaosa 5642e01
feat: add client upload progress
joaosa 1f600c3
chore: relock deps
joaosa 2c73702
fix: blob add upload progress implementation
joaosa 50929e6
chore: address linter errors
joaosa 9391a86
fix: test blob upload on w3up-client tests
joaosa 45507f2
chore: cleanup upload-client test code
joaosa 0896614
fix: pass w3up-client upload tests
joaosa 7552e9b
fix: missing import
joaosa 4eee857
chore: appease prettier
joaosa 24a99e9
fix: address w3up upload test expectations
joaosa c6aaa04
feat: implement blob/remove
joaosa 65dfee1
feat: implement blob/list
joaosa 21e2973
fix: pass blob protocol upload-client tests
joaosa f9c4043
chore: address coverage for upload-client blob
joaosa 5196f9c
feat: add w3up-client upload-client blob boilerplate
joaosa 5bad45f
fix: blob add (#1442)
Gozala e4ab876
fix: replace blob protocol CAR params with blobs
joaosa 3825838
fix: use the bytes field of a multihash
joaosa f31e2f0
fix: replace CAR usage with blobs
joaosa 722fec0
fix: cleanup blob interfaces
joaosa 1294cf9
fix: cover blob client tests
joaosa 726f2d7
fix: move c8 ignore block
joaosa 6ab2ffc
fix: use allocations storate for w3up blob client test
joaosa 6cf26eb
fix: address typo
joaosa e5916a8
chore: remove unneeded boilerplate
joaosa 9bb3d11
chore: remove blank comment line
joaosa e9a7edb
chore: fix blob/add param description
joaosa 6ae74f8
chore: fix blob/list description
joaosa 4f71107
chore: fix typo
joaosa 6704748
fix: use the store/list capability
joaosa 42bd997
chore: fix blob/add description
joaosa b9eaeea
chore: replace test CARs with bytes
joaosa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think this is the quirk that @Gozala is going to fix today 🤞. I think it's ok to do here, but not necessary in production.
The code that stores invocations and receipts runs in w3infra. So this should be done automatically for you in
allocate.execute(...)
below.In the tests here, there's no code that does this automatically, which is why in tests you see this: https://github.com/w3s-project/w3up/blob/f8132ca1fced72a4addc7e9f0a2162e823c1ea5f/packages/upload-api/test/helpers/blob.js#L113-L115
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually part of @Gozala's PR into my branch, but good to get more context 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I have added this before I realized what was going on, I have branch that I'm actively trying to finish that should fix this and will remove these lines also.